feat: add `reduce` and `reduceRight` methods to `array/bool` #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kgryte merged 5 commits into stdlib-js:develop from Jaysukh-409:reduce-reduceRight

Jul 5, 2024

Member

Jaysukh-409 commented Jul 4, 2024

Resolves: Subtask of #2304

Description

What is the purpose of this pull request?

This pull request:

Adds the typed array reduce and reduceRight methods to prototype of BooleanArray

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers


          feat: add reduce and reduceRight methods to array/bool

c32e56e

Jaysukh-409 added the Feature label

Jaysukh-409 commented

View reviewed changes

lib/node_modules/@stdlib/array/bool/benchmark/benchmark.reduce.js Outdated Show resolved Hide resolved

Jaysukh-409 commented

View reviewed changes

lib/node_modules/@stdlib/array/bool/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/README.md Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/benchmark/benchmark.reduce.length.js Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/benchmark/benchmark.reduce.length.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/benchmark/benchmark.reduce.length.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/benchmark/benchmark.reduce.length.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/benchmark/benchmark.reduce_right.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/benchmark/benchmark.reduce_right.length.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/docs/repl.txt Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/docs/repl.txt Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/test/test.reduce.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/test/test.reduce.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/test/test.reduce.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/test/test.reduce.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/test/test.reduce.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/test/test.reduce.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/test/test.reduce_right.js Outdated Show resolved Hide resolved

kgryte requested changes

View reviewed changes

Member

kgryte left a comment

This PR needs a good bit of clean-up. All comments should be straightforward to address.


          feat: apply suggested changes

bdfe900

Jaysukh-409 requested a review from kgryte

July 5, 2024 11:56

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/docs/repl.txt Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/docs/repl.txt Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/docs/repl.txt Outdated Show resolved Hide resolved


          Apply suggestions from code review

Signed-off-by: Athan <[email protected]>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/docs/types/index.d.ts Outdated Show resolved Hide resolved


          Apply suggestions from code review

3695bb2

Signed-off-by: Athan <[email protected]>

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/array/bool/lib/main.js Outdated Show resolved Hide resolved


          Apply suggestions from code review

dbfba53

Signed-off-by: Athan <[email protected]>

kgryte approved these changes

View reviewed changes

Member

kgryte left a comment

LGTM. Thanks, @Jaysukh-409!

kgryte merged commit 4a6be43 into stdlib-js:develop

kgryte deleted the reduce-reduceRight branch

July 5, 2024 18:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature